[webkit-reviews] review granted: [Bug 195657] [ContentChangeObserver] HTMLImageElement::willRespondToMouseClickEvents returns quirk value. : [Attachment 364842] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 195657: [ContentChangeObserver]
HTMLImageElement::willRespondToMouseClickEvents returns quirk value.
https://bugs.webkit.org/show_bug.cgi?id=195657

Attachment 364842: Patch

https://bugs.webkit.org/attachment.cgi?id=364842&action=review




--- Comment #10 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 364842
  --> https://bugs.webkit.org/attachment.cgi?id=364842
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364842&action=review

> Source/WebCore/ChangeLog:9
> +	   Wait and see if we could actually remove this quirk.

Pls update.

> Source/WebCore/page/ios/ContentChangeObserver.cpp:406
>      if (!m_hadRenderer)
> -	   return
const_cast<Element&>(m_element).willRespondToMouseClickEvents();
> +	   return element.willRespondToMouseClickEvents();
>      ASSERT(m_element.renderer());
> -    if (const_cast<Element&>(m_element).willRespondToMouseClickEvents())
> +    if (element.willRespondToMouseClickEvents())
>	   return true;

Maybe flip this logic around to have just one call to
element.willRespondToMouseClickEvents