[webkit-reviews] review granted: [Bug 195636] Add new NSAttributedString API for converting HTML : [Attachment 364817] Patch 3 / 4

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 195636: Add new NSAttributedString API for converting HTML
https://bugs.webkit.org/show_bug.cgi?id=195636

Attachment 364817: Patch 3 / 4

https://bugs.webkit.org/attachment.cgi?id=364817&action=review




--- Comment #49 from Tim Horton <thorton at apple.com> ---
Comment on attachment 364817
  --> https://bugs.webkit.org/attachment.cgi?id=364817
Patch 3 / 4

View in context: https://bugs.webkit.org/attachment.cgi?id=364817&action=review

> Source/WebKit/UIProcess/WebPageProxy.h:299
> +#if PLATFORM(COCOA)

Do we have to #ifdef all these things, I wonder? AttributedString is
cross-platform, just empty

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:89
> +	   EXPECT_WK_STREQ(@"sRGB IEC61966-2.1 colorspace 1 0 0 1",
dynamic_objc_cast<PlatformColor>(documentAttributes[NSBackgroundColorDocumentAt
tribute]).description);

I wonder if this is actually a safe thing to check. Maybe convert to sRGB and
test the components?