[webkit-reviews] review granted: [Bug 195733] [Async overflow scrolling] Update positioned node layers when overflows are scrolled : [Attachment 364737] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 195733: [Async overflow scrolling] Update positioned node layers when
overflows are scrolled
https://bugs.webkit.org/show_bug.cgi?id=195733

Attachment 364737: Patch

https://bugs.webkit.org/attachment.cgi?id=364737&action=review




--- Comment #10 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 364737
  --> https://bugs.webkit.org/attachment.cgi?id=364737
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364737&action=review

r=me

> Source/WebCore/page/scrolling/cocoa/ScrollingTreePositionedNode.mm:80
> +    // Note that we ignore cumulativeDelta because it will contain the delta
for ancestor scrollers,
> +    // but not non-ancestor ones, so it's simpler to just recompute from the
scrollers we know about here.

Would be nice to have a single unified way to do this everywhere.