[webkit-reviews] review granted: [Bug 195752] [JSC] DFG OSR entry tends to reject Double and AnyInt values : [Attachment 364680] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 195752: [JSC] DFG OSR entry tends to reject Double and AnyInt values
https://bugs.webkit.org/show_bug.cgi?id=195752

Attachment 364680: Patch

https://bugs.webkit.org/attachment.cgi?id=364680&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 364680
  --> https://bugs.webkit.org/attachment.cgi?id=364680
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364680&action=review

> Source/JavaScriptCore/ChangeLog:3
> +	   [JSC] DFG OSR entry tends to reject Double and AnyInt values

nit: this makes it seem like this is a longstanding issue. It's not. It
regressed only recently. It'd be good for this title to acknowledge that this
just regressed.

> Source/JavaScriptCore/ChangeLog:8
> +	   We fix the bug skipping AbstractValue validations when the flush
format is Double or AnyInt. But it

you should say what revision.
"fix" => "fixed"