[webkit-reviews] review granted: [Bug 195782] Remove retain cycle from JSScript and also don't keep the cache file descriptor open so many JSScripts can be cached in a loop : [Attachment 364726] patch

[bugzilla-daemon at webkit.org]

Michael Saboff <msaboff at apple.com> has granted Saam Barati
<sbarati at apple.com>'s request for review:
Bug 195782: Remove retain cycle from JSScript and also don't keep the cache
file descriptor open so many JSScripts can be cached in a loop
https://bugs.webkit.org/show_bug.cgi?id=195782

Attachment 364726: patch

https://bugs.webkit.org/attachment.cgi?id=364726&action=review




--- Comment #4 from Michael Saboff <msaboff at apple.com> ---
Comment on attachment 364726
  --> https://bugs.webkit.org/attachment.cgi?id=364726
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364726&action=review

r=me

> Source/JavaScriptCore/API/JSScript.mm:290
> +	   error = "No cache was path provided during construction of this
JSScript."_s;

I know you didn't change this error message, but shouldn't it read "No cache
*path was* provided during construction of this JSScript."?