[webkit-reviews] review requested: [Bug 195734] Web Inspector: Network - Toggle Between Live Activity and Imported HAR resource collections : [Attachment 364731] [PATCH] Proposed Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 14 17:37:20 PDT 2019


Joseph Pecoraro <joepeck at webkit.org> has asked	for review:
Bug 195734: Web Inspector: Network - Toggle Between Live Activity and Imported
HAR resource collections
https://bugs.webkit.org/show_bug.cgi?id=195734

Attachment 364731: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=364731&action=review




--- Comment #8 from Joseph Pecoraro <joepeck at webkit.org> ---
Created attachment 364731

  --> https://bugs.webkit.org/attachment.cgi?id=364731&action=review

[PATCH] Proposed Fix

I agree the `this._collections` set approach is much cleaner. This also
addresses a few subtle bugs.


More information about the webkit-reviews mailing list