[webkit-reviews] review granted: [Bug 195781] [Web GPU] GPUAdapter.createDevice -> GPUAdapter.requestDevice : [Attachment 364720] Patch

[bugzilla-daemon at webkit.org]

Myles C. Maxfield <mmaxfield at apple.com> has granted Justin Fan
<justin_fan at apple.com>'s request for review:
Bug 195781: [Web GPU] GPUAdapter.createDevice -> GPUAdapter.requestDevice
https://bugs.webkit.org/show_bug.cgi?id=195781

Attachment 364720: Patch

https://bugs.webkit.org/attachment.cgi?id=364720&action=review




--- Comment #2 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 364720
  --> https://bugs.webkit.org/attachment.cgi?id=364720
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364720&action=review

> Source/WebCore/Modules/webgpu/WebGPUAdapter.cpp:49
> +	   promise.resolve(device.releaseNonNull());

Are you sure that releaseNonNull is the right thing here?