[webkit-reviews] review granted: [Bug 190350] [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing : [Attachment 364660] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 190350: [ Mojave WK1 ] Layout Test
storage/indexeddb/database-odd-names.html is failing
https://bugs.webkit.org/show_bug.cgi?id=190350

Attachment 364660: Patch

https://bugs.webkit.org/attachment.cgi?id=364660&action=review




--- Comment #21 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 364660
  --> https://bugs.webkit.org/attachment.cgi?id=364660
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364660&action=review

r=me if you resolve Youenn's comments

> Source/WebCore/Modules/indexeddb/server/IDBServer.cpp:850
> +    String newVersionDirectory =
FileSystem::pathByAppendingComponent(m_databaseDirectoryPath, "v1");

It's probably worth adding a comment here to explain that the UI process
creates the v0 symlink.