[webkit-reviews] review granted: [Bug 195754] Move CoreCrypto SPI declarations to an appropriate PAL/spi header : [Attachment 364674] Patch

[bugzilla-daemon at webkit.org]

Jiewen Tan <jiewen_tan at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 195754: Move CoreCrypto SPI declarations to an appropriate PAL/spi header
https://bugs.webkit.org/show_bug.cgi?id=195754

Attachment 364674: Patch

https://bugs.webkit.org/attachment.cgi?id=364674&action=review




--- Comment #5 from Jiewen Tan <jiewen_tan at apple.com> ---
Comment on attachment 364674
  --> https://bugs.webkit.org/attachment.cgi?id=364674
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364674&action=review

Thanks Brent for making this change. Really appreciate it. r=me.

> Source/WebCore/ChangeLog:3
> +	   Move CoreCrypto SPI declarations to an appropriate PAL/spi header

CommonCrypto will be more appropriate.

> Source/WebCore/ChangeLog:9
> +	   Move the forward declarations of various CoreCrypto SPI to an
appropriate PAL/spi header.

Ditto.

> Source/WebCore/PAL/ChangeLog:3
> +	   Move CoreCrypto SPI declarations to an appropriate PAL/spi header

Ditto.

> Source/WebCore/PAL/ChangeLog:9
> +	   Move the forward declarations of various CoreCrypto SPI to an
appropriate PAL/spi header.

Ditto.