[webkit-reviews] review granted: [Bug 195732] Web Inspector: REGRESSION: Canvas: the first processed action should be selected as soon as it's available if no previous selected action exists : [Attachment 364620] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 14 11:43:11 PDT 2019


Matt Baker <mattbaker at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 195732: Web Inspector: REGRESSION: Canvas: the first processed action
should be selected as soon as it's available if no previous selected action
exists
https://bugs.webkit.org/show_bug.cgi?id=195732

Attachment 364620: Patch

https://bugs.webkit.org/attachment.cgi?id=364620&action=review




--- Comment #4 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 364620
  --> https://bugs.webkit.org/attachment.cgi?id=364620
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364620&action=review

r=me

> Source/WebInspectorUI/ChangeLog:11
> +	   Rather than wait till the entire recording is ready, set the
selected action as soon as the

s/till/until

> Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.js:581
> +	       this.action = action;

So `action` here is equivalent to this._recording.actions[0], if the recording
were ready?


More information about the webkit-reviews mailing list