[webkit-reviews] review granted: [Bug 195740] [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window : [Attachment 364652] Patch

[bugzilla-daemon at webkit.org]

Ross Kirsling <ross.kirsling at sony.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 195740: [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to
open a new window
https://bugs.webkit.org/show_bug.cgi?id=195740

Attachment 364652: Patch

https://bugs.webkit.org/attachment.cgi?id=364652&action=review




--- Comment #2 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 364652
  --> https://bugs.webkit.org/attachment.cgi?id=364652
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364652&action=review

Seems fine overall from my perspective.

> Tools/MiniBrowser/win/MainWindow.h:36
> +    using BrowserWindowFactory = std::function<Ref<BrowserWindow>(HWND
mainWnd, HWND urlBarWnd, bool usesLayeredWebView, bool pageLoadTesting)>;

Shouldn't this be WTF::Function?

> Tools/MiniBrowser/win/WebKitBrowserWindow.cpp:304
> +    auto& thisWindow = toWebKitBrowserWindow(clientInfo);

Doesn't look like you're using this one.