[webkit-reviews] review granted: [Bug 195735] ASSERTION FAILED: regexp->isValid() or ASSERTION FAILED: !isCompilationThread() : [Attachment 364634] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Michael Saboff <msaboff at apple.com>'s
request for review:
Bug 195735: ASSERTION FAILED: regexp->isValid() or ASSERTION FAILED:
!isCompilationThread()
https://bugs.webkit.org/show_bug.cgi?id=195735

Attachment 364634: Patch

https://bugs.webkit.org/attachment.cgi?id=364634&action=review




--- Comment #4 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 364634
  --> https://bugs.webkit.org/attachment.cgi?id=364634
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364634&action=review

r=me if EWS bots are happy.

> Source/JavaScriptCore/ChangeLog:18
> +	   The second but is due to incorrect logic when we go to run the
regexp in the Strength Reduction phase.

/but/bug/.