[webkit-reviews] review granted: [Bug 195279] Fixup uses KnownInt32 incorrectly in some nodes : [Attachment 364618] patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 195279: Fixup uses KnownInt32 incorrectly in some nodes
https://bugs.webkit.org/show_bug.cgi?id=195279

Attachment 364618: patch

https://bugs.webkit.org/attachment.cgi?id=364618&action=review




--- Comment #21 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 364618
  --> https://bugs.webkit.org/attachment.cgi?id=364618
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364618&action=review

r=me

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:8678
>  

You can remove `DFG_ASSERT(m_jit.graph(), node, !needsTypeCheck(element,
SpecDoubleReal));` in the loop too.

> Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:4728
>  

I think removing L4762-4763 and L4767 would be nice for consistency.