[webkit-reviews] review granted: [Bug 195691] [bmalloc] Add StaticPerProcess for known types to save pages : [Attachment 364582] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 195691: [bmalloc] Add StaticPerProcess for known types to save pages
https://bugs.webkit.org/show_bug.cgi?id=195691

Attachment 364582: Patch

https://bugs.webkit.org/attachment.cgi?id=364582&action=review




--- Comment #5 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 364582
  --> https://bugs.webkit.org/attachment.cgi?id=364582
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364582&action=review

r=me

> Source/bmalloc/ChangeLog:11
> +	   size if we keep in mind that the current fast malloc heap size is
488KB. Putting them into a __DATA, close to the other mutable data, can save
this page.

/into a __DATA/into the __DATA section/
/, can save this page/, we can avoid allocating this page/

> Source/bmalloc/ChangeLog:13
> +	   This patch revives SafePerProcess concept in r228107. We add
"StaticPerProcess<T>", which allocates underlying storage statically in __DATA
section instead of

...revives the SafePerProcess...
... in the __DATA section ...

> Source/bmalloc/bmalloc/Gigacage.cpp:67
> +}

nit: Add // namespace bmalloc

> Source/bmalloc/bmalloc/StaticPerProcess.h:34
> +// StaticPerProcess<T> behaves like PerProcess<T>, but we must need to
explicitly define a storage for T with EXTERN.

/must need to/need to/ and /define a storage/define storage/

> Source/bmalloc/bmalloc/StaticPerProcess.h:35
> +// In this way, we allocate a storage for a per-process object statically
instead of allocating memory at runtime.

/allocate a storage/allocate storage/

> Source/bmalloc/bmalloc/StaticPerProcess.h:51
> +// Object will be instantiated only once, even in the face of concurrency.

/the face of/the presence of/