[webkit-reviews] review granted: [Bug 195705] Web Inspector: Debugger: pausing in an inline script on a page with a URL query creates an Extra Script : [Attachment 364581] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 13 15:24:51 PDT 2019


Antoine Quint <graouts at apple.com> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 195705: Web Inspector: Debugger: pausing in an inline script on a page with
a URL query creates an Extra Script
https://bugs.webkit.org/show_bug.cgi?id=195705

Attachment 364581: Patch

https://bugs.webkit.org/attachment.cgi?id=364581&action=review




--- Comment #3 from Antoine Quint <graouts at apple.com> ---
Comment on attachment 364581
  --> https://bugs.webkit.org/attachment.cgi?id=364581
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364581&action=review

> Source/WebInspectorUI/UserInterface/Models/Script.js:280
> +	       let mainResource = this._target === WI.mainTarget ?
WI.networkManager.mainFrame.mainResource : this._target.mainResource;

Not sure if there's a coding style I don't know about, but technically `const`
here would work since mainResource is not re-assigned.


More information about the webkit-reviews mailing list