[webkit-reviews] review granted: [Bug 195702] Block all plugins smaller than 5x5px : [Attachment 364578] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Dean Jackson <dino at apple.com>'s request
for review:
Bug 195702: Block all plugins smaller than 5x5px
https://bugs.webkit.org/show_bug.cgi?id=195702

Attachment 364578: Patch

https://bugs.webkit.org/attachment.cgi?id=364578&action=review




--- Comment #3 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 364578
  --> https://bugs.webkit.org/attachment.cgi?id=364578
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364578&action=review

> Source/WebCore/ChangeLog:10
> +	   5x5px. Other browsers have implemented this for a while, and now

s/5x5px/5pxx5px/ :)

> Source/WebKitLegacy/mac/ChangeLog:25
> +2019-03-13  Dean Jackson  <dino at apple.com>
> +
> +	   Block all plugins smaller than 5x5px
> +	   https://bugs.webkit.org/show_bug.cgi?id=195702
> +	   <rdar://problem/28435204>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Removed a function that was never being called.
> +
> +	   * WebCoreSupport/WebFrameLoaderClient.h:
> +	   * WebCoreSupport/WebFrameLoaderClient.mm:
> +	   (WebFrameLoaderClient::recreatePlugin): Deleted.
> +
> +2019-03-13  Dean Jackson  <dino at apple.com>
> +
> +	   Block all plugins smaller than 5x5px
> +	   https://bugs.webkit.org/show_bug.cgi?id=195702
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   * WebCoreSupport/WebFrameLoaderClient.h:
> +	   * WebCoreSupport/WebFrameLoaderClient.mm:
> +	   (WebFrameLoaderClient::recreatePlugin): Deleted.
> +

Double ChangeLog!

> Source/WebCore/platform/LocalizedStrings.cpp:683
> +    return WEB_UI_STRING_KEY("Plug-in too small", "Plug-In too small",
"Label text to be used when a plug-in was blocked from loading because it was
too small");

You have different capitalization of "plug-in" in the first two strings. Is
that intentional?

> LayoutTests/plugins/small-plugin-blocked.html:34
> +<embed id="plugin3" type="application/x-webkit-test-netscape" width="4"
height="4"></embed>

Probably want to do one on the boundary, 5px, as well.	And maybe one that has
a width too small, but a big height or vice versa.