[webkit-reviews] review granted: [Bug 195593] [JSC] Move species watchpoint installation from ArrayPrototype to JSGlobalObject : [Attachment 364337] Patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 195593: [JSC] Move species watchpoint installation from ArrayPrototype to
JSGlobalObject
https://bugs.webkit.org/show_bug.cgi?id=195593

Attachment 364337: Patch

https://bugs.webkit.org/attachment.cgi?id=364337&action=review




--- Comment #6 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 364337
  --> https://bugs.webkit.org/attachment.cgi?id=364337
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364337&action=review

r=me.

> Source/JavaScriptCore/runtime/ArrayPrototype.cpp:200
> +	   if (ArrayPrototypeInternal::verbose)
> +	       dataLog("Initializing Array species watchpoints for
Array.prototype: ", pointerDump(arrayPrototype), " with structure: ",
pointerDump(arrayPrototype->structure(vm)), "\nand Array: ",
pointerDump(globalObject->arrayConstructor()), " with structure: ",
pointerDump(globalObject->arrayConstructor()->structure(vm)), "\n");

Nit: I prefer dataLogLnIf(ArrayPrototypeInternal::verbose, ...)