[webkit-reviews] review granted: [Bug 195684] REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate : [Attachment 364560] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 195684: REGRESSION(PSON, r240660): Navigation over process boundary is
flashy when using Cmd-left/right arrow to navigate
https://bugs.webkit.org/show_bug.cgi?id=195684

Attachment 364560: Patch

https://bugs.webkit.org/attachment.cgi?id=364560&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 364560
  --> https://bugs.webkit.org/attachment.cgi?id=364560
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364560&action=review

> Source/WebCore/ChangeLog:12
> +	   When a navigation is triggered by JS (and not the client), we create
the Navigation object in

Cmd-left/right arrow involves JS?

> Source/WebCore/ChangeLog:22
> +	   This is a lot error prone, the WebProcess knows more accurately
which history items it is going

"a lot error prone"