[webkit-reviews] review granted: [Bug 195634] Use new RegistrableDomain type in PSON code : [Attachment 364425] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 13 10:45:01 PDT 2019

youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 195634: Use new RegistrableDomain type in PSON code

Attachment 364425: Patch


--- Comment #5 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 364425
  --> https://bugs.webkit.org/attachment.cgi?id=364425

View in context: https://bugs.webkit.org/attachment.cgi?id=364425&action=review

> Source/WebKit/UIProcess/WebProcessProxy.h:118
> +    WebCore::RegistrableDomain registrableDomain() const { return
m_registrableDomain.valueOr(WebCore::RegistrableDomain { }); }

It seems we can have m_registrableDomain being nullopt, isEmpty or being a real
registrable domain.
But we do not expose the difference between nullopt and isEmpty in the public
Can it be a potential source of issues in the future?

More information about the webkit-reviews mailing list