[webkit-reviews] review granted: [Bug 195658] Enable libwebrtc logging control through WebCore : [Attachment 364538] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 13 09:32:40 PDT 2019

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 195658: Enable libwebrtc logging control through WebCore

Attachment 364538: Patch


--- Comment #4 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 364538
  --> https://bugs.webkit.org/attachment.cgi?id=364538

View in context: https://bugs.webkit.org/attachment.cgi?id=364538&action=review

> Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:228
> +    if (!m_enableLogging)

Logging can never be enabled once it has been disabled?

More information about the webkit-reviews mailing list