[webkit-reviews] review granted: [Bug 195673] [GStreamer][WebRTC] Do not sync encoder on the clock : [Attachment 364527] Patch

[bugzilla-daemon at webkit.org]

Philippe Normand <pnormand at igalia.com> has granted Thibault Saunier
<tsaunier at gnome.org>'s request for review:
Bug 195673: [GStreamer][WebRTC] Do not sync encoder on the clock
https://bugs.webkit.org/show_bug.cgi?id=195673

Attachment 364527: Patch

https://bugs.webkit.org/attachment.cgi?id=364527&action=review




--- Comment #2 from Philippe Normand <pnormand at igalia.com> ---
Comment on attachment 364527
  --> https://bugs.webkit.org/attachment.cgi?id=364527
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364527&action=review

>
Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:
145
> +	   g_object_set(sink, "sync", FALSE, NULL);

Please at least remain consistent with the code below and use nullptr :)