[webkit-reviews] review granted: [Bug 194597] [ews-app] status bubble should be hidden for certain builds : [Attachment 364484] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 13 00:10:39 PDT 2019


dewei_zhu at apple.com has granted Aakash Jain <aakash_jain at apple.com>'s request
for review:
Bug 194597: [ews-app] status bubble should be hidden for certain builds
https://bugs.webkit.org/show_bug.cgi?id=194597

Attachment 364484: Proposed patch

https://bugs.webkit.org/attachment.cgi?id=364484&action=review




--- Comment #2 from dewei_zhu at apple.com ---
Comment on attachment 364484
  --> https://bugs.webkit.org/attachment.cgi?id=364484
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364484&action=review

> Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:88
> +	   if build and build.result == 3 and re.search(r'Patch .* doesn\'t
have relevant changes', build.state_string):

Maybe having class variables for SUCCESS, WARNINGS, FAILURE, SKIPPED and RETRY
make this code also StatusBubble._build_bubble more readable. What do you
think?


More information about the webkit-reviews mailing list