[webkit-reviews] review denied: [Bug 195361] A single leading space is not considered as a word break even when word-break: break-all is set : [Attachment 364486] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Javier Fernandez
<jfernandez at igalia.com>'s request for review:
Bug 195361: A single leading space is not considered as a word break even when
word-break: break-all is set
https://bugs.webkit.org/show_bug.cgi?id=195361

Attachment 364486: Patch

https://bugs.webkit.org/attachment.cgi?id=364486&action=review




--- Comment #27 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 364486
  --> https://bugs.webkit.org/attachment.cgi?id=364486
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364486&action=review

> Source/WebCore/rendering/line/BreakingContext.h:823
> +	   if (m_atStart && m_currentCharacterIsSpace &&
!previousCharacterIsSpace)
> +	       breakWords = false;

This isn't right. breakWords is always false hereafter for every character.
We also need a new test for this given this change's bug didn't get caught by
any existing test.
r-