[webkit-reviews] review granted: [Bug 195647] Add WebFrameProxy::loadData : [Attachment 364463] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 195647: Add WebFrameProxy::loadData
https://bugs.webkit.org/show_bug.cgi?id=195647

Attachment 364463: Patch

https://bugs.webkit.org/attachment.cgi?id=364463&action=review




--- Comment #4 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 364463
  --> https://bugs.webkit.org/attachment.cgi?id=364463
Patch

It might be good to add a test for that if it is difficult to test it without
additional features.

Maybe we could expose a private API on the web view for testing purposes only.
This API could take a frameId and some data to be loaded.
TestRunner would then grab the frameId and call that new API.

View in context: https://bugs.webkit.org/attachment.cgi?id=364463&action=review

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:1401
> +    SubstituteData substituteData(WTFMove(sharedBuffer), URL(),
WTFMove(response), SubstituteData::SessionHistoryVisibility::Hidden);

It is true that the above code is not doing that but I would tend to set the
correct URL in both response and substituteData.