[webkit-reviews] review granted: [Bug 195573] Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding : [Attachment 364409] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 12 13:30:06 PDT 2019


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Robin Morisset
<rmorisset at apple.com>'s request for review:
Bug 195573: Alter Tools/Scripts/dump-class-layout to be able to dump all
classes with suspicious padding
https://bugs.webkit.org/show_bug.cgi?id=195573

Attachment 364409: Patch

https://bugs.webkit.org/attachment.cgi?id=364409&action=review




--- Comment #9 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 364409
  --> https://bugs.webkit.org/attachment.cgi?id=364409
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364409&action=review

> Tools/Scripts/dump-class-layout:88
> +    if args.all_wasteful and (args.classname is not None):
> +	   print "The -w/--all-wasteful option is incompatible with providing a
class name"

Maybe we should allow multiple classnames, and then you could just handle both.


More information about the webkit-reviews mailing list