[webkit-reviews] review granted: [Bug 195633] Web Inspector: Elements: provide node context menu items for event listeners sorted by node : [Attachment 364413] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 12 12:08:51 PDT 2019


Matt Baker <mattbaker at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 195633: Web Inspector: Elements: provide node context menu items for event
listeners sorted by node
https://bugs.webkit.org/show_bug.cgi?id=195633

Attachment 364413: Patch

https://bugs.webkit.org/attachment.cgi?id=364413&action=review




--- Comment #2 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 364413
  --> https://bugs.webkit.org/attachment.cgi?id=364413
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364413&action=review

r=me, but I think the bug title should be changed. Context menu items aren't
added anywhere; this looks like refactoring.

> Source/WebInspectorUI/ChangeLog:12
> +	   existing DOM without modifying it.

This is confusing: "...so it can be used on existing DOM without modifying it."
Aren't we just separating this out so it can be reused?


More information about the webkit-reviews mailing list