[webkit-reviews] review granted: [Bug 195522] Web Inspector: DOM Debugger: remove left padding when the last DOM breakpoint is removed : [Attachment 364136] Patch

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 195522: Web Inspector: DOM Debugger: remove left padding when the last DOM
breakpoint is removed
https://bugs.webkit.org/show_bug.cgi?id=195522

Attachment 364136: Patch

https://bugs.webkit.org/attachment.cgi?id=364136&action=review




--- Comment #2 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 364136
  --> https://bugs.webkit.org/attachment.cgi?id=364136
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364136&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js:782
> +	   this.breakpointGutterEnabled =
this._domTreeOutline.children.some((child) => child.hasBreakpoint);

Nice! I think keeping the early return makes it read better, and with your
changes it's cleaner still:

if (!breakpoints.length) {
    treeElement.breakpointStatus = WI.DOMTreeElement.BreakpointStatus.None;
    return;
}

if (breakpoints.some((item) => item.disabled))
    treeElement.breakpointStatus =
WI.DOMTreeElement.BreakpointStatus.DisabledBreakpoint;
else
    treeElement.breakpointStatus =
WI.DOMTreeElement.BreakpointStatus.Breakpoint;

this.breakpointGutterEnabled = this._domTreeOutline.children.some((child) =>
child.hasBreakpoint);