[webkit-reviews] review granted: [Bug 190350] [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing : [Attachment 364390] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 190350: [ Mojave WK1 ] Layout Test
storage/indexeddb/database-odd-names.html is failing
https://bugs.webkit.org/show_bug.cgi?id=190350

Attachment 364390: Patch

https://bugs.webkit.org/attachment.cgi?id=364390&action=review




--- Comment #14 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 364390
  --> https://bugs.webkit.org/attachment.cgi?id=364390
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364390&action=review

r=me

> Tools/TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm:72
> +

Can you add a test for removing website data, when the data has only a v0
IndexedDB entry, or only a v1 IndexedDB entry? (It looks like
IndexedDBUserDelete.mm will test removing a fully unmigrated database path.)