[webkit-reviews] review granted: [Bug 195569] Web Inspector: use -webkit-{margin, padding}-{start, end} instead of [dir={ltr/rtl}] rules : [Attachment 364301] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 11 16:49:21 PDT 2019

Matt Baker <mattbaker at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 195569: Web Inspector: use -webkit-{margin,padding}-{start,end} instead of
[dir={ltr/rtl}] rules

Attachment 364301: Patch


--- Comment #4 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 364301
  --> https://bugs.webkit.org/attachment.cgi?id=364301

View in context: https://bugs.webkit.org/attachment.cgi?id=364301&action=review

r=me, great cleanup!

> Source/WebInspectorUI/UserInterface/Views/BreakpointPopoverController.css:81
> +#edit-breakpoint-popover-auto-continue {

Style: these should be on a single line.

> Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.css:48
> +.content-view.dom-tree.show-gutter .tree-outline.dom {

This rule belongs in DOMTreeContentView.css.

> Source/WebInspectorUI/UserInterface/Views/FindBanner.css:69
> +.find-banner > :first-child {

So much better!

> Source/WebInspectorUI/UserInterface/Views/HierarchicalPathComponent.css:143
> +    /* Positions so the text in the menu aligns with the text in .title for
text only path components. */

"text-only" should be hyphenated, since it's a compound adjective preceding the
noun it modifies.

More information about the webkit-reviews mailing list