[webkit-reviews] review granted: [Bug 195473] [iOS] Implement a faster click detection that intercepts double-tap-to-zoom if possible : [Attachment 364295] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Dean Jackson
<dino at apple.com>'s request for review:
Bug 195473: [iOS] Implement a faster click detection that intercepts
double-tap-to-zoom if possible
https://bugs.webkit.org/show_bug.cgi?id=195473

Attachment 364295: Patch

https://bugs.webkit.org/attachment.cgi?id=364295&action=review




--- Comment #17 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 364295
  --> https://bugs.webkit.org/attachment.cgi?id=364295
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364295&action=review

> Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:815
> +void WebPageProxy::potentialTapAtPosition(const WebCore::FloatPoint&
position, bool requestingMagnificationInformation, uint64_t& requestID)

Nit - is it intended that requestMagnificationInformation in WKContentView
becomes requestingMagnificationInformation in WebPageProxy? I think it might be
better to use a consistent name for the "should I request magnification info"
flag (maybe the name could just be shouldRequestMagnificationInformation).

> LayoutTests/resources/ui-helper.js:79
> +	   console.assert(this.isIOS());

Nit - Generally speaking, UIHelper methods should work cross-platform if at all
possible. We should probably use eventSender to make it work in the non-iOS
case (or at least replace the console.assert(this.isIOS()) with a FIXME to
implement it elsewhere).