[webkit-reviews] review granted: [Bug 195575] [Synthetic Click] Dispatch mouseout soon after mouseup : [Attachment 364296] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 195575: [Synthetic Click] Dispatch mouseout soon after mouseup
https://bugs.webkit.org/show_bug.cgi?id=195575

Attachment 364296: Patch

https://bugs.webkit.org/attachment.cgi?id=364296&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 364296
  --> https://bugs.webkit.org/attachment.cgi?id=364296
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364296&action=review

> Source/WebCore/ChangeLog:5
> +	   <rdar://problem/48784946>

Use the other radar.

> Source/WebCore/page/ios/EventHandlerIOS.mm:518
> +void EventHandler::dispatchFakeMouseOut(const PlatformMouseEvent&
platformMouseEvent)

We should use a standard term: fake or synthetic

> Source/WebCore/page/ios/EventHandlerIOS.mm:520
> +    updateMouseEventTargetNode(nullptr, platformMouseEvent, true);

Maybe an enum instead of 'true'