[webkit-reviews] review granted: [Bug 195484] [iOS] Block access to backboardd service : [Attachment 364275] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 11 12:28:45 PDT 2019


Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 195484: [iOS] Block access to backboardd service
https://bugs.webkit.org/show_bug.cgi?id=195484

Attachment 364275: Patch

https://bugs.webkit.org/attachment.cgi?id=364275&action=review




--- Comment #8 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 364275
  --> https://bugs.webkit.org/attachment.cgi?id=364275
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364275&action=review

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:711
> +

I think you should have a FIXME comment referencing the radar where the
relevant backlight code will be improved in the future so we don't have to do
this silly swizzling.


More information about the webkit-reviews mailing list