[webkit-reviews] review denied: [Bug 185211] JavaScriptCore should throw TypeError if [[OwnPropertyKeys]] returns duplicate entries : [Attachment 362914] [JSC] throw if ownKeys Proxy trap result contains duplicate keys

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 11 11:10:51 PDT 2019


Saam Barati <sbarati at apple.com> has denied Caitlin Potter (:caitp)
<caitp at igalia.com>'s request for review:
Bug 185211: JavaScriptCore should throw TypeError if [[OwnPropertyKeys]]
returns duplicate entries
https://bugs.webkit.org/show_bug.cgi?id=185211

Attachment 362914: [JSC] throw if ownKeys Proxy trap result contains duplicate
keys

https://bugs.webkit.org/attachment.cgi?id=362914&action=review




--- Comment #13 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 362914
  --> https://bugs.webkit.org/attachment.cgi?id=362914
[JSC] throw if ownKeys Proxy trap result contains duplicate keys

View in context: https://bugs.webkit.org/attachment.cgi?id=362914&action=review

> Source/JavaScriptCore/runtime/ProxyObject.cpp:959
> +	   }

I believe this is the cause of your build issues.


More information about the webkit-reviews mailing list