[webkit-reviews] review granted: [Bug 195330] Improve normalization code, including moving from unorm.h to unorm2.h : [Attachment 364195] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Darin Adler
<darin at apple.com>'s request for review:
Bug 195330: Improve normalization code, including moving from unorm.h to
unorm2.h
https://bugs.webkit.org/show_bug.cgi?id=195330

Attachment 364195: Patch

https://bugs.webkit.org/attachment.cgi?id=364195&action=review




--- Comment #19 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 364195
  --> https://bugs.webkit.org/attachment.cgi?id=364195
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364195&action=review

There's also FontCairoHarfbuzzNG.cpp which could be converted to use the new
normalizedNFC() function. Should be straightforward, if you're brave and want
to touch a file you can't build.

> Source/WTF/wtf/text/StringView.h:216
> +WTF_EXPORT_PRIVATE StringViewWithUnderlyingString normalizedNFC(StringView);

Wouldn't it be simpler to just return a String and let the API user create the
StringView?

> Source/WebCore/editing/TextIterator.cpp:2017
>  static void normalizeCharacters(const UChar* characters, unsigned length,
Vector<UChar>& buffer)

Shame we can't use your new normalizedNFC() function here. Oh well. :(