[webkit-reviews] review denied: [Bug 195484] [iOS] Block access to backboardd service : [Attachment 364081] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 11 09:48:46 PDT 2019


Brent Fulgham <bfulgham at webkit.org> has denied Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 195484: [iOS] Block access to backboardd service
https://bugs.webkit.org/show_bug.cgi?id=195484

Attachment 364081: Patch

https://bugs.webkit.org/attachment.cgi?id=364081&action=review




--- Comment #5 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 364081
  --> https://bugs.webkit.org/attachment.cgi?id=364081
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364081&action=review

> Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:403
> +   
CFNotificationCenterAddObserver(CFNotificationCenterGetDarwinNotifyCenter(),
this, backlightLevelDidChangeCallback,
(CFStringRef)UIBacklightLevelChangedNotification, nullptr,
CFNotificationSuspensionBehaviorCoalesce);

You might need to forward declare UIBacklightLevelChangedNotification, perhaps
in an SPI file. Or you might just be missing a relevant include.


More information about the webkit-reviews mailing list