[webkit-reviews] review denied: [Bug 195464] [macOS] Remove the Kerberos rules from the WebContent sandbox : [Attachment 364044] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 11 09:34:17 PDT 2019


Brent Fulgham <bfulgham at webkit.org> has denied	review:
Bug 195464: [macOS] Remove the Kerberos rules from the WebContent sandbox
https://bugs.webkit.org/show_bug.cgi?id=195464

Attachment 364044: Patch

https://bugs.webkit.org/attachment.cgi?id=364044&action=review




--- Comment #21 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 364044
  --> https://bugs.webkit.org/attachment.cgi?id=364044
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364044&action=review

r- to remove the conditional check and just remove the GSS access.

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:694
> +#if __MAC_OS_X_VERSION_MIN_REQUIRED < 101500

As discussed in the bug, we shouldn't need this version check since all WebKit
builds (even to downlevel OSes) have all such interactions happening in the
Network Process.


More information about the webkit-reviews mailing list