[webkit-reviews] review granted: [Bug 195453] [GStreamer][v4l2] Synchronous video texture flushing support : [Attachment 364246] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 195453: [GStreamer][v4l2] Synchronous video texture flushing support
https://bugs.webkit.org/show_bug.cgi?id=195453

Attachment 364246: Patch

https://bugs.webkit.org/attachment.cgi?id=364246&action=review




--- Comment #8 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 364246
  --> https://bugs.webkit.org/attachment.cgi?id=364246
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364246&action=review

>
Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxy.cpp:228
> +    m_bufferDropped = false;

Shouldn't this line be protected by the lock?

> Source/WebCore/platform/graphics/texmap/TextureMapperPlatformLayerProxy.h:91
> +    Lock m_conditionLock;
> +    Condition m_condition;
> +    bool m_bufferDropped { false };

m_[wasB|b]ufferDroppedLock, m_[wasB|b]ufferDroppedCondition,
m_wasBufferDropped.