[webkit-reviews] review granted: [Bug 195547] Web Inspector: CPU Usage Timeline - Better Thread chart layout values : [Attachment 364240] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 195547: Web Inspector: CPU Usage Timeline - Better Thread chart layout
values
https://bugs.webkit.org/show_bug.cgi?id=195547

Attachment 364240: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=364240&action=review




--- Comment #2 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 364240
  --> https://bugs.webkit.org/attachment.cgi?id=364240
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=364240&action=review

rs=me

> Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.js:463
> +	   let workerMax = 0;

Any reason to not use `-Infinity` like the rest?

> Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.js:601
> +	       if (value > 75)
> +		   return 100;
> +	       if (value > 50)
> +		   return 75;
> +	       if (value > 25)
> +		   return 50;
> +	       return 25;

NIT: this could be rewritten/simplified as `(Math.floor(value / 25) + 1) * 25`.