[webkit-reviews] review granted: [Bug 195536] Fix some misleading function and variable names in WKContentViewInteraction.mm : [Attachment 364207] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Mar 10 16:15:52 PDT 2019
Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 195536: Fix some misleading function and variable names in
WKContentViewInteraction.mm
https://bugs.webkit.org/show_bug.cgi?id=195536
Attachment 364207: Patch
https://bugs.webkit.org/attachment.cgi?id=364207&action=review
--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 364207
--> https://bugs.webkit.org/attachment.cgi?id=364207
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=364207&action=review
> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:-4726
> -static bool shouldZoomToRevealSelectionRect(WebKit::InputType type)
“Misleading” is an understatement
More information about the webkit-reviews
mailing list