[webkit-reviews] review denied: [Bug 195361] A single leading space is not considered as a word break even when word-break: break-all is set : [Attachment 364087] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Javier Fernandez
<jfernandez at igalia.com>'s request for review:
Bug 195361: A single leading space is not considered as a word break even when
word-break: break-all is set
https://bugs.webkit.org/show_bug.cgi?id=195361

Attachment 364087: Patch

https://bugs.webkit.org/attachment.cgi?id=364087&action=review




--- Comment #23 from Darin Adler <darin at apple.com> ---
Comment on attachment 364087
  --> https://bugs.webkit.org/attachment.cgi?id=364087
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364087&action=review

>> Source/WebCore/rendering/line/BreakingContext.h:847
>> +	    if ((breakAll || breakWords) && !midWordBreak &&
(!m_currentCharacterIsSpace || m_atStart || style.whiteSpace() !=
WhiteSpace::PreWrap)) {
> 
> This seems to also affect `line-break: break-word`. That doesn't seem right.
> `line-break: break-word` should be treated like `line-break: normal`:
> https://drafts.csswg.org/css-text-3/#valdef-word-break-break-word
> 
> We need a test for this case.

review- because of this comment