[webkit-reviews] review granted: [Bug 195516] Optimizing loads when creating new pages : [Attachment 364178] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jiewen Tan <jiewen_tan at apple.com>'s
request for review:
Bug 195516: Optimizing loads when creating new pages
https://bugs.webkit.org/show_bug.cgi?id=195516

Attachment 364178: Patch

https://bugs.webkit.org/attachment.cgi?id=364178&action=review




--- Comment #8 from Darin Adler <darin at apple.com> ---
Comment on attachment 364178
  --> https://bugs.webkit.org/attachment.cgi?id=364178
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364178&action=review

r+ so Jiewen can keep making progress

>> Source/WebKit/UIProcess/WebPageProxy.h:2191
>> +#endif
> 
> How do these hooks work?
> 
> It's strange that we would have non-open source code tightly coupled to open
source like this. It's one thing to depend on an internal library, or to
provide APIs for use by internal code, but just #including secret code into
WebKit internals like this seems... unusual.
> 
> What gets optimized?

I understand your unease. But this has happened multiple times before before
when an engineer at Apple started development on something that Apple wasn't
ready to reveal. I think it’s OK for now; we can discuss it in more detail when
someone from Apple upstreams everything. And it’s all inside an #if.