[webkit-reviews] review granted: [Bug 195523] [Cocoa] Code signing fails because services are copied into XPCServices after the framework is signed : [Attachment 364140] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Darin Adler <darin at apple.com>'s request for review:
Bug 195523: [Cocoa] Code signing fails because services are copied into
XPCServices after the framework is signed
https://bugs.webkit.org/show_bug.cgi?id=195523

Attachment 364140: Patch

https://bugs.webkit.org/attachment.cgi?id=364140&action=review




--- Comment #4 from mitz at webkit.org ---
Comment on attachment 364140
  --> https://bugs.webkit.org/attachment.cgi?id=364140
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364140&action=review

Looks good overall. Should the new script build phase’s output paths be
populated with the paths of the symlinks? Maybe there’s no harm in having the
script run even if they exist.

Another concern is whether the script needs to check if there exists a
directory where it wants to create the symlink, and delete it, so that the
transition to this new way of building doesn’t require people to manually
delete some of the built product.

> Source/WebKit/WebKit.xcodeproj/project.pbxproj:10675
> +			shellScript = "if [[ \"${CONFIGURATION}\" ==
\"Production\" ]]; then\n    exit\nfi\n\nif [[ ${WK_PLATFORM_NAME} !=
\"macosx\" ]]; then\n	
XPC_SERVICES_PATH=\"${BUILT_PRODUCTS_DIR}/WebKit.framework/XPCServices\"\n   
BUILT_PRODUCTS_DIR_RELATIVE_PATH_FROM_XPC_SERVICES=\"../..\"\nelse\n   
XPC_SERVICES_PATH=\"${BUILT_PRODUCTS_DIR}/WebKit.framework/Versions/A/XPCServic
es\"\n	 
BUILT_PRODUCTS_DIR_RELATIVE_PATH_FROM_XPC_SERVICES=\"../../../..\"\nfi\n\nmkdir
-p \"${XPC_SERVICES_PATH}\"\nln -sfh
\"${BUILT_PRODUCTS_DIR_RELATIVE_PATH_FROM_XPC_SERVICES}/com.apple.WebKit.WebCon
tent.xpc\" \"${XPC_SERVICES_PATH}/com.apple.WebKit.WebContent.xpc\"\nln -sfh
\"${BUILT_PRODUCTS_DIR_RELATIVE_PATH_FROM_XPC_SERVICES}/com.apple.WebKit.Networ
king.xpc\" \"${XPC_SERVICES_PATH}/com.apple.WebKit.Networking.xpc\"\nln -sfh
\"${BUILT_PRODUCTS_DIR_RELATIVE_PATH_FROM_XPC_SERVICES}/${WK_STORAGE_SERVICE_PR
ODUCT_NAME}.xpc\"
\"${XPC_SERVICES_PATH}/${WK_STORAGE_SERVICE_PRODUCT_NAME}.xpc\"\n\nif [[
${WK_PLATFORM_NAME} == macosx ]]; then\n    ln -sfh
\"${BUILT_PRODUCTS_DIR_RELATIVE_PATH_FROM_XPC_SERVICES}/com.apple.WebKit.Plugin
.32.xpc\" \"${XPC_SERVICES_PATH}/com.apple.WebKit.Plugin.xpc\"\n    ln -sfh
\"${BUILT_PRODUCTS_DIR_RELATIVE_PATH_FROM_XPC_SERVICES}/com.apple.WebKit.Plugin
.64.xpc\" \"${XPC_SERVICES_PATH}/com.apple.WebKit.Plugin.64.xpc\"\nfi\n";

We can remove references to the 32-bit plug-in service, which no longer exists.