[webkit-reviews] review granted: [Bug 195520] [ContentChangeObserver] Click event fires immediately on hover menu at seriouseats.com : [Attachment 364130] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 195520: [ContentChangeObserver] Click event fires immediately on hover menu
at seriouseats.com
https://bugs.webkit.org/show_bug.cgi?id=195520

Attachment 364130: Patch

https://bugs.webkit.org/attachment.cgi?id=364130&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 364130
  --> https://bugs.webkit.org/attachment.cgi?id=364130
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364130&action=review

> Source/WebCore/ChangeLog:9
> +	   Unfortunately seriouseats has a 300ms hover intent delay to deal
with accidental menupane pop-ups.

Maybe say something about the other changes in this patch.

> Source/WebCore/page/ios/ContentChangeObserver.cpp:352
> +    if (style.hasOutOfFlowPosition() && left.isFixed() && left.value() <=
-999)
> +	   return true;

What about negative X?
Don't you also need to check the element width? Something at -999 could be
on-screen, especially if it has 100% width on iPad.
You should also add a test for this.