[webkit-reviews] review granted: [Bug 195471] Web Inspector: CPU Usage Timeline - Enable by default : [Attachment 364034] [PATCH] Proposed Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 8 17:56:34 PST 2019

Devin Rousso <drousso at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 195471: Web Inspector: CPU Usage Timeline - Enable by default

Attachment 364034: [PATCH] Proposed Fix


--- Comment #2 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 364034
  --> https://bugs.webkit.org/attachment.cgi?id=364034
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=364034&action=review


> Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js:113
> +	   if (WI.CPUInstrument.supported())
> +	       defaultTypes.push(WI.TimelineRecord.Type.CPU);

Should we put this above the FPS instrument, seeing as it's shown in the same
grouping as the other default types (e.g. the rendering frame timeline is a
separate "view"/"tab" from Network/Layout/Script)?

More information about the webkit-reviews mailing list