[webkit-reviews] review granted: [Bug 195478] [ContentChangeObserver] Expand "isConsideredClickable" to descendants : [Attachment 364069] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Mar 8 14:48:24 PST 2019
Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 195478: [ContentChangeObserver] Expand "isConsideredClickable" to
descendants
https://bugs.webkit.org/show_bug.cgi?id=195478
Attachment 364069: Patch
https://bugs.webkit.org/attachment.cgi?id=364069&action=review
--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 364069
--> https://bugs.webkit.org/attachment.cgi?id=364069
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=364069&action=review
> Source/WebCore/ChangeLog:9
> + In StyleChangeScope we try to figure out whether a newly visible
content should stick (menu panes etc) by checking if it is clickable.
"newly visible content"?
> Source/WebCore/page/ios/ContentChangeObserver.cpp:310
> + if (!m_wasHidden || isConsideredHidden())
Would be clearer as if (changedFromHiddenToVisible())
More information about the webkit-reviews
mailing list