[webkit-reviews] review denied: [Bug 195225] Check whether to launch a default action instead of action sheet : [Attachment 363953] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has denied Jennifer Moore
<Jennifer.moore at apple.com>'s request for review:
Bug 195225: Check whether to launch a default action instead of action sheet
https://bugs.webkit.org/show_bug.cgi?id=195225

Attachment 363953: Patch

https://bugs.webkit.org/attachment.cgi?id=363953&action=review




--- Comment #27 from Tim Horton <thorton at apple.com> ---
Comment on attachment 363953
  --> https://bugs.webkit.org/attachment.cgi?id=363953
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363953&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1220
> +	   [_actionSheetAssistant interactionDidStart];

I apologize for not looking more carefully at this patch earlier.

-interactionDidStart is called on every touchBegin, and calls
-synchronouslyRetrievePositionInformation, which is incredibly expensive and
blocks the main thread. We can't do that.