[webkit-reviews] review granted: [Bug 195454] [MSE][GStreamer] Increase currentTime accuracy on pause/play and remove superfluous timeUpdate events : [Attachment 364006] Patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Enrique Ocaña
<eocanha at igalia.com>'s request for review:
Bug 195454: [MSE][GStreamer] Increase currentTime accuracy on pause/play and
remove superfluous timeUpdate events
https://bugs.webkit.org/show_bug.cgi?id=195454

Attachment 364006: Patch

https://bugs.webkit.org/attachment.cgi?id=364006&action=review




--- Comment #4 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 364006
  --> https://bugs.webkit.org/attachment.cgi?id=364006
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364006&action=review

This looks fine to me with a minor nit which could be addressed before landing.

> Source/WebCore/html/HTMLMediaElement.cpp:3594
> +	   m_lastTimeUpdateEventMovieTime = currentMediaTime();

There is a slight inefficiency here, in that calling currentMediaTime() will go
down all the way to the MediaPlayerPrivate again (and could have a different
answer the second time!). So I would slightly refactor this so that
m_lstTimeUpdateEventMovieTime was set before m_playbackStartedTime, and the
playback value was just generated from the update value.