[webkit-reviews] review granted: [Bug 195449] [JSC] Make more fields lazy in JSGlobalObject : [Attachment 363979] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 7 21:14:06 PST 2019


Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 195449: [JSC] Make more fields lazy in JSGlobalObject
https://bugs.webkit.org/show_bug.cgi?id=195449

Attachment 363979: Patch

https://bugs.webkit.org/attachment.cgi?id=363979&action=review




--- Comment #4 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 363979
  --> https://bugs.webkit.org/attachment.cgi?id=363979
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363979&action=review

r=me

> Source/JavaScriptCore/runtime/JSGlobalObject.cpp:317
> +  eval		   JSGlobalObject::m_evalFunction	       
DontEnum|CellProperty

Should you group this with the other CellPropertys below?  This list isn't in
alphabetical order anyway.


More information about the webkit-reviews mailing list