[webkit-reviews] review granted: [Bug 195429] [JSC] Remove merging must handle values into proven types in CFA : [Attachment 363926] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 7 17:36:08 PST 2019


Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 195429: [JSC] Remove merging must handle values into proven types in CFA
https://bugs.webkit.org/show_bug.cgi?id=195429

Attachment 363926: Patch

https://bugs.webkit.org/attachment.cgi?id=363926&action=review




--- Comment #4 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 363926
  --> https://bugs.webkit.org/attachment.cgi?id=363926
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363926&action=review

> Source/JavaScriptCore/ChangeLog:45
> +	   Since (1) this is just an optimization, (2) type information is
already propagated in prediction injection phase, and (3) the must handle value
does not show the performance

We should make these separate bugs and patches. r=me on both.


More information about the webkit-reviews mailing list