[webkit-reviews] review granted: [Bug 194806] IndexedDB: re-enable some leak tests : [Attachment 363946] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 7 16:09:17 PST 2019


Geoffrey Garen <ggaren at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 194806: IndexedDB: re-enable some leak tests
https://bugs.webkit.org/show_bug.cgi?id=194806

Attachment 363946: Patch

https://bugs.webkit.org/attachment.cgi?id=363946&action=review




--- Comment #9 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 363946
  --> https://bugs.webkit.org/attachment.cgi?id=363946
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363946&action=review

r=me

> Source/WebCore/Modules/indexeddb/IDBCursor.cpp:350
> +void IDBCursor::clearRequest()

I think we need a lock here too because we clear wrappers.


More information about the webkit-reviews mailing list